From aeb1ca9d3ed225d6a96e3d812d742ea915b3f4cf Mon Sep 17 00:00:00 2001 From: Aleksei Date: Sat, 11 Apr 2020 19:32:44 -0400 Subject: [PATCH] Auto-closed insert ResultSet --- .../dev/salmonllama/fsbot/database/DatabaseProvider.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/main/java/dev/salmonllama/fsbot/database/DatabaseProvider.java b/src/main/java/dev/salmonllama/fsbot/database/DatabaseProvider.java index c38ab73..e514bc8 100644 --- a/src/main/java/dev/salmonllama/fsbot/database/DatabaseProvider.java +++ b/src/main/java/dev/salmonllama/fsbot/database/DatabaseProvider.java @@ -79,12 +79,13 @@ public class DatabaseProvider { } public int insert(String sql, Object... params) throws SQLException { - try (PreparedStatement query = getConnection().prepareStatement(sql, Statement.RETURN_GENERATED_KEYS)) { + try ( + PreparedStatement query = getConnection().prepareStatement(sql, Statement.RETURN_GENERATED_KEYS); + ResultSet rs = query.getGeneratedKeys() + ) { resolveParameters(query, params); query.executeUpdate(); - ResultSet rs = query.getGeneratedKeys(); - if (rs.next()) { return rs.getInt(1); }